vk-cs / terraform-provider-vkcs

Mozilla Public License 2.0
41 stars 13 forks source link

Update code structure #162

Closed paaanic closed 1 year ago

paaanic commented 1 year ago

vkcs:

Also, in order to simplify provider.go, where all data_sources and resources are listed, we could add files data_sources.go and resources.go to each of services folders. This сan be even done by code generation.

Interesting example of service related settings: https://github.com/hashicorp/terraform-provider-azurerm/blob/main/internal/services/databricks/registration.go.

CMPT-31302

ftersin commented 1 year ago

Could we remove serive name from file names in subfolers?

ftersin commented 1 year ago

lb files should not be in db folder

paaanic commented 1 year ago

lb files should not be in db folder

Sure, don't know how it got there.

paaanic commented 1 year ago

Could we remove serive name from file names in subfolers?

Yes. But this approach also has advantages: the file name corresponds to name of resource/datasource, and I believe this structure should be consistent with the upcoming documentation, grouped by service, where these names should remain full.

ftersin commented 1 year ago

hmm... This also has another one - an ability to organize code similar to doc structure, if the last one does not follow service names

ftersin commented 1 year ago

done