search

vkaravir / JSAV

JavaScript Algorithm Visualization library
MIT License
112 stars 40 forks source link

Added drag-and-drop sortability option to AV arrays #168

Closed X455u closed 10 years ago

X455u commented 10 years ago

Added option to create an AV array where you can drag and drop the values instead of having to use swaps.

Is it OK that this is part of JSAV, or do you think it should be an extension?

X455u commented 10 years ago

Wakey wakey... :)

Any comments?

cashaffer commented 10 years ago

It would be nice to add exercises like the one that you showed the link to (though, we could also implement the same thing in the Khan Academy infrastructure now). My big concern is: Who is responsible for ensuring that Sortable.js is available to the exercise? I am a little bit worried about a proliferation of that sort of dependency.

vkaravir commented 10 years ago

Aren't you impatient ;)

I don't think we can include this in JSAV (or OpenDSA). Sortable.js doesn't have any kind of license, so it cannot be distributed with OpenDSA or JSAV. Also, since we are already using jQuery-UI, it would probably be better to use the sortable feature of it.

Btw, can these sortable arrays be used in simulation exercises? I mean can animation steps be added after each move made by a student and the sequence graded? If not, I'm not sure what's the role of JSAV here and agree with Cliff that these could well be implemented with Khan Academy.

X455u commented 10 years ago

Sorry, but we have a course starting next week, and we would like to use sorting exercises in our course.

For me it seems like they are using MIT licence (line 4 of the source code)

The reason why I chose Sortable.js is because it also works with touch devices. jQuery-UI doesn't seem to work with mobile devices unless you add an extra JavaScript file to enable it.

The drag-and-drop steps are recorded in the sortable arrays, and you can make them gradable like I did in the example I included in the pull request. So you can also use undo in the example to undo a step.

I can still implement this as an extension if you want.

cashaffer commented 10 years ago

I can still implement this as an extension if you want.

I am still waiting on Ville to answer my questions about where he wants to go with extensions. :)

and you can make them gradable like I did in the example I included in the pull request. So you can also use undo in the example to undo a step.

I can't tell by looking at the example that this relates in any way to a JSAV proficiency exercise in terms of underlying technology. Can you turn this example into something that looks like a the other JSAV-based proficiency exercises (with scoring and a model answer)? (I would use it in my class if you did. I don't know how to use it in OpenDSA in its current form.)

X455u commented 10 years ago

This example does not use JSAV or OpenDSA in any way. It would however be convenient to use the infrastructure of JSAV and OpenDSA for this type of exercises. That's why I made the pull request.

The example I mentioned in my earlier comment actually referred to the example in the pull request. I don't have an online example of it, but you can check the source for it here. This example uses the finalStep grader, so you only get one point if everything is correct. Otherwise you get zero points.

X455u commented 10 years ago

I have turned this pull request into an extension, and pushed it to the Development folder in the OpenDSA project repository. The proficiency exercise example can be found here:

OpenDSA/AV/Development/SortableArrayTest.html

vkaravir commented 10 years ago

Sorry, but we have a course starting next week, and we would like to use sorting exercises in our course.

Sorry for the delays, my course started this week so things have been a bit hectic..

For me it seems like they are using MIT licence (line 4 of the source code)

Sorry again, I only checked the README and repository for the license, should've read the source.

I can still implement this as an extension if you want.

I'd prefer this to be an extension, since I don't really see the connection to JSAV or the need for such a feature in JSAV arrays. Like said, this kind of exercises would probably make more sense as Khan Academy exercises.

vkaravir commented 10 years ago

Seems like you commented while I had the pull request open :)

So this PR can be closed?

X455u commented 10 years ago

Yes, this pull request can be closed.

Do you want a pull request for the extension?

vkaravir commented 10 years ago

We're still undecided on where the extensions should live in. We have options JSAV, OpenDSA, or another extension repository. I'll include you in our email discussion.