vkarpov15 / temporal-rest

22 stars 4 forks source link

NestJS module and Amplication integration #5

Open joebowbeer opened 2 years ago

joebowbeer commented 2 years ago

This looks great.

Consider making a NestJS module

Examples:

I'm also imagining an Amplication integration where the whole app could be generated.

https://amplication.com/

vkarpov15 commented 2 years ago

@joebowbeer I haven't worked with NestJS before, I started putting together a basic example of how one might use Temporal with NestJS here: https://github.com/vkarpov15/typescript-starter-with-temporal/commit/e76a0848d4e59fd913bc6894cda1b0ed3c299dc6

Can you please take a look and let me know if you have any thoughts on this sample app?

joebowbeer commented 2 years ago

@vkarpov15 That looks like a good start.

An async provider for the workflow handle looks like the right approach.

I added single line comments.

I'm not sure where the worker file should live, by the way.

Maybe this will eventually earn a listing at https://github.com/nestjs/awesome-nestjs