search

vkeroles / EEP153-SP23-Proj3

0 stars 0 forks source link

Code review from Team F #8

Open saaaallYao opened 1 year ago

saaaallYao commented 1 year ago

Hi, the code is really clear and well-structured, but here are some areas of small improvement:

  1. For the first two graphs for soft drink and flour, I understand that the three curves represent three different quantiles, but it would be great if you can provide a legend or instruction to it for an easier understanding.
  2. For the very last graph, the legend blocks the view of the graph.

Team F

vkeroles commented 1 year ago

Thank you for the feedback. Added legends for first two graphs, please let me know if this is adequate. For the very last graph, I was able to move the legend to not block the view of the plot but will still need to work on making the entire legend visible.

vkeroles commented 1 year ago

We have decided to provide the last graph with the top 10 items in the legend, all visible