swift build error doesn't show diagnostics

haifengkao commented 5 years ago

Expected The diagnostics shows the location of error

Actual The diagnostics is empty

when swift build failed, stderr is empty string but stdout has all the error messages if I remove if (stderr), the diagnostics displays correctly.

// SwiftTool.js
sb.on("exit", function (code, signal) {
        clientMain_1.trace(`***swift build command exited*** code: ${code}, signal: ${signal}`);
        clientMain_1.dumpInConsole("\n");
        clientMain_1.diagnosticCollection.clear();

        if (stderr) {
            dumpDiagnostics();
        }

vknabel commented 5 years ago

@haifengkao Good catch! Would you like to create a PR for this?

vknabel commented 4 years ago

Has been fixed with latest release 2.8.2

haifengkao commented 4 years ago

too bad I didn't see your comment earlier :(

vknabel / vscode-swift-development-environment

swift build error doesn't show diagnostics #57