vknabel / vscode-swift-development-environment

New home of Swift Development Environment for VS Code
https://marketplace.visualstudio.com/items?itemName=vknabel.vscode-swift-development-environment
Apache License 2.0
175 stars 14 forks source link

Remote Running in containers on Linux #72

Closed cloudnull closed 4 years ago

cloudnull commented 4 years ago

Thank you for maintaining this extension. This issue is not so much a bug, but a request for review. I created an updated container definition using swift 5.2 and I would appreciate it if you could give that a look, as it relies on your extension to be successful: https://github.com/microsoft/vscode-dev-containers/pull/356

The crux of the container setup is the following settings JSON. I think it would be great to get something like that into the readme, so other linux workstation users can use the extension out of the box (in my case fedora).

    "settings": {
        "terminal.integrated.shell.linux": "/bin/bash",
        "lldb.adapterType": "bundled",
        "lldb.executable": "/usr/bin/lldb",
        "sde.languageservermode": "sourcekit",
        "sourcekit-lsp.serverPath": "/usr/bin/sourcekit-lsp",
        "sourcekit-lsp.toolchainPath": "/workspaces/",
    }

Thanks again for the extension, and feel free to close this issue whenever.

vknabel commented 4 years ago

@cloudnull looks great! I haven't used vscode dev containers yet, but it looks really promising! Might actually give it a try soon!

Feel free to open a PR that updates the readme. E.g. add a new FAQ question under FAQ.

I see two variants:

This helps reducing confusion and prevents issues being opened in the wrong repository.


Regarding your settings:

cloudnull commented 4 years ago

Thanks for the review, I'll close this out and follow up with PR to the README and docs.

  • sde.languageServerMode's

Done.

  • "sourcekit-lsp.toolchainPath": "/workspaces/"

I actually don't know if this is needed, I was just setting it to the workspace path which vscode autobinds, however, I play with it and see if I can delete it.