Allow lang server restart

vknabel / vscode-swift-development-environment

New home of Swift Development Environment for VS Code

https://marketplace.visualstudio.com/items?itemName=vknabel.vscode-swift-development-environment

Apache License 2.0

175 stars 14 forks source link

Allow lang server restart #85

Closed clayreimann closed 3 years ago

clayreimann commented 3 years ago

A bunch of refactoring as well as adding commands for swift clean, swift run, and restarting the language server.

vknabel commented 3 years ago

Great changes so far! I had quite a lot to do the last weeks. Should be better this month. :)

clayreimann commented 3 years ago

@vknabel A lot of progress here.

The language server can be restarted (I've only confirmed sourcekitd because that's what I use)
Added commands to run, stop, clean
Cleaned up (IMO) the code for better understanding and maintenance

Could be merged as-is, but I think the configuration still needs to be cleaned up a bit. (It should all use the same prefix sde.SECTION.setting and I'd like to export an object from the configuration helper that mirrors the options–but allows us to hide the specific configuration names so we can migrate from what is to the new strings.)

clayreimann commented 3 years ago

Actually @vknabel I think it would make sense to merge this without the settings cleanup so we can better pinpoint where any bugs come from.

This is already a pretty major rewrite and changing how we fetch config any more seems like asking for more headaches

vknabel commented 3 years ago

Hey @clayreimann. Sorry for the late response and a huge thank you for all your amazing work!

I have already started reviewing this PR. I will try to test everything as good as possible (on macOS and Linux), which is quite time consuming, but it will be worth it.

Once I find bugs, I will probably fix them directly, if that's okay for you.

Currently I am not sure how we handle the release and renamed configs or commands. Technically it would be a breaking change and would require a major version bump. But this should be fine. Might be a great opportunity to delete unused features.

vknabel commented 3 years ago

Thanks a lot @clayreimann! I know it took quite a while. This PR really helps in the long term! In https://github.com/vknabel/vscode-swift-development-environment/commit/b247437aece010a44341b91d51fa933c93d044ed I made a few fixes, added some changelogs and mentioned you in the README.

vknabel commented 3 years ago

I created a beta release tag: 2.11.0-beta.0.

I try to test it bit, but I believe it should work fine. Will release it soon.