Generate table from CSV doesn't work with Umlauts

vkocubinsky / SublimeTableEditor

This package is no more supported. I moved to vim.

Other

494 stars 67 forks source link

Generate table from CSV doesn't work with Umlauts #44

Closed gwiltschek closed 10 years ago

gwiltschek commented 10 years ago

Trying to generate a Table from CSV data containing german umlauts (ä, ö, ü) won't work (at least with Sublime Text 2 on Windows 7).

Example: A;B;C;D 2Ä;2B;3C;4D

vkocubinsky commented 10 years ago

I saw this, this is the bug. I saw stack trace after click ctrl~

UnicodeEncodeError: 'ascii' codec can't encode character u'\xc4' in position 1: ordinal not in range(128)
Traceback (most recent call last):
  File ".\sublime_plugin.py", line 362, in run_
  File ".\table_plugin.py", line 178, in run
  File ".\table_plugin.py", line 442, in run_one_sel
  File ".\table_base.py", line 740, in parse_csv
UnicodeEncodeError: 'ascii' codec can't encode character u'\xc4' in position 1: ordinal not in range(128)

vkocubinsky commented 10 years ago

In ST3 it works, for ST2 I have fixed in st2 branch, I guess new version will be available automatically, but I will check in Monday on my office workstation is it true.

The problem was in python 2.7 csv module doesn't work with unicode and fix is encode to bytes before work with csv module and then decode to unicode after.

vkocubinsky commented 10 years ago

Checked for windows and mac. It works as expected now