vkonst / ctd-token

Smart-contracts for Cointed Token and Token Sale
11 stars 9 forks source link

function create() redundant checks #9

Closed tghdev closed 6 years ago

tghdev commented 6 years ago

The modifier whenNotClosed applied to function create() requires a Phase != AfterICO. Within the function the if statement in Line 119 is therefore redundant, because it is always true if the modifier doesn't throw. Hence, the else statement in Line 151 will never be triggered.

ilejn commented 6 years ago

Phase can be altered by "adjustPhaseBasedOnTime" method.

vkonst commented 6 years ago

Not an issue

As @ilejn mentioned, the phase can be altered by the adjustPhaseBasedOnTime method. Therefore the check is required.

Thank you both for your input.