vkostyukov / kotlin-sublime-package

Sublime Text 2 Package for Kotlin Programming Language
Apache License 2.0
137 stars 41 forks source link

Trying to fix #19, #18, #6, #4 and #8 #20

Closed belyaev-mikhail closed 6 years ago

belyaev-mikhail commented 6 years ago

Also:

Checked in sublime 2, dunno about other usecases.

belyaev-mikhail commented 6 years ago

And #9 :-)

jcornaz commented 6 years ago

Thanks for your PR, it solves my problems in Sublime3 too.

I'm now waiting it to be merged, so that github highlighting will follow.

pchaigno commented 6 years ago

@vkostyukov Did you get a chance to look into this pull request?

belyaev-mikhail commented 6 years ago

@pchaigno Seems like a lost cause to me)

JLLeitschuh commented 6 years ago

@vkostyukov Would you be willing to take a look at this?

@pchaigno Perhaps the Github team would be willing to pull this project under their wing in order to allow contributors to fix these issues so they can be made available to Github?

belyaev-mikhail commented 6 years ago

@JLLeitschuh There is another project that is currently listed at linguist repo as the kotlin grammar. It is certainly better than current version of this repo, but may not be better than this PR.

I'm currently trying to convince the Kotlin team to take it under Jetbrains' wing, which seems to be the better option for everybody.

JLLeitschuh commented 6 years ago

I sent an email to the repo owner.

vkostyukov commented 6 years ago

Thanks for your patience @JLLeitschuh and @belyaev-mikhail! I'm going to merge this in to unblock people short-term. I don't mind (and fully support) if either Github or Jetbrains want to fork this project and evolve it on their own terms.

pchaigno commented 6 years ago

Thank you @vkostyukov for taking the time!

Perhaps the Github team would be willing to pull this project under their wing in order to allow contributors to fix these issues so they can be made available to Github?

The issue is not so much who owns the repo, but rather who maintains it. You need people to review fixes.

I'm currently trying to convince the Kotlin team to take it under Jetbrains' wing, which seems to be the better option for everybody.

:+1: