search

vkostyukov / la4j

Linear Algebra for Java
http://la4j.org
Apache License 2.0
373 stars 107 forks source link

Solved #177 and #124 #197

Closed SamoylovMD closed 10 years ago

SamoylovMD commented 10 years ago

More details: Added remove row/column methods to Matrix (issue #177) Added new class LeastNormSolver (issue #124)

vkostyukov commented 10 years ago

Maxim @SamoylovMD,

Cool! Thanks a lot! I've commented the RP: just a couple of code style concerns. Please fix them.

Could you also please slipt the PR into 2: LeastNormSolution and removeRow/removeColumn parts. It's better to review them separatelly.

And having a test-cases for removeRow/removeColumn is also a good thing. Please, add a couple of new tests for new methods.

SamoylovMD commented 10 years ago

Unfortunately I don't know how to split PRs.

vkostyukov commented 10 years ago

@SamoylovMD, sorry for the deally and thanks for the PR!