202 matrix range check - Githubissues

vkostyukov / la4j

Linear Algebra for Java

http://la4j.org

Apache License 2.0

373 stars 109 forks source link

Closed DWiechert closed 9 years ago

DWiechert commented 9 years ago

Added range checking for CRS and CCS Matricies. This should be the last bit to close #202.

vkostyukov commented 9 years ago

@DWiechert, thanks a lot! This looks very nice. Just a couple of concerns about indentation and tests.

DWiechert commented 9 years ago

@vkostyukov, I've made those code review changes you suggested. When you get a chance can you please take another look?

vkostyukov commented 9 years ago

@DWiechert everything looks cool now. Just a small concern about unnecessary call at get.

DWiechert commented 9 years ago

I've removed the double range checks in SparseVector and AbstractCompressedMatrix.

vkostyukov commented 9 years ago

Thanks a lot!