search

vkostyukov / la4j

Linear Algebra for Java
http://la4j.org
Apache License 2.0
371 stars 109 forks source link

Fixed some bugs #283

Closed nunomiguel1995 closed 7 years ago

nunomiguel1995 commented 7 years ago

After running Codacy in this project we noticed that the error prone could be improved. We corrected some of the bugs shown such as missing default clause in a switch, modifying variables received by parameter, etc. After fixing these bugs the error prone improved.

maseev commented 7 years ago

That's weird. I keep getting notifications every time you update this PR. I don't see any user mentioning, though. Looks like your PR contains some images and a lot of *.md files. Do you really want them to end up in the project's repository?

maseev commented 7 years ago

Looks like I subscribed to any changes to this project. Sorry guys! :smile:

nunomiguel1995 commented 7 years ago

This is a PR for our class in university. We have a folder with reports, which I believe is what you're mentioning. This folder isn't supposed to end up in the project's repository, but I don't know if I have made any mistake making the pull request :P

maseev commented 7 years ago

@nunomiguel1995 I think it will be better if you remove all university stuff from the PR and squash all the commits in one. In the end @vkostyukov decides how PRs get merged here :wink:

nunomiguel1995 commented 7 years ago

@maseev The thing is, I'm supposed to have the reports in the PR, but I think I will fork the main project again and put the changes there and then remake the pull-request

vkostyukov commented 7 years ago

What is happening here, @nunomiguel1995?

I'm happy to accept a PR that cleans up code / fixes bugs. Although, this PR doesn't look like anything to me. I'm closing this for now. Please, feel free to reopen when you're confident in the changes in your branch.

nunomiguel1995 commented 7 years ago

@vkostyukov I'm sorry, I believe you're talking about all the notifications? My group and I have a repository for our class and we have some reports there. We might have make a mistake while PR'ing and now you are receiving all the notifications from everything we change there. We're going to try to fix that and then re-open the PR. Again, sorry for all this mess :P