vkostyukov / la4j

Linear Algebra for Java
http://la4j.org
Apache License 2.0
373 stars 108 forks source link

SparseMatrix.zero uses CCSMatrix instead of CRSMatrix? #311

Closed alexanderwlee closed 2 years ago

alexanderwlee commented 2 years ago

Please correct me if I am wrong, but it seems like the default matrix for the SparseMatrix class is the CRSMatrix. If this is the case, why are we calling CCSMatrix.zero in SparseMatrix.zero? Shouldn't the method call CRSMatrix.zero instead? https://github.com/vkostyukov/la4j/blob/dd1b917caf9606399a49afa6b0d738934cd3a7b3/src/main/java/org/la4j/matrix/SparseMatrix.java#L59-L65

Anyways, thanks for the amazing library!