search

vkoves / carpe

Scheduling for the modern age - an UNMAINTAINED indigoBox project
http://carpe-uno.herokuapp.com
0 stars 0 forks source link

Events in monthly view can be placed on top of multiple days simultaneously #124

Open Watercycle opened 7 years ago

Watercycle commented 7 years ago

It doesn't seem to cause any saving issues, it's just visually undesirable. When the mouse is released, the event defaults to going to the right side.

untitled

vkoves commented 7 years ago

Worth noting this is tied into PR #113, but was designated low priority and thus will not be fixed before that is merged in.

SorenSpicknall commented 6 years ago

I'm not of the opinion that this requires as fix. The event simply sticks to whichever day the cursor is on when released, which seems like natural behavior. If events stayed within the boundaries of a single day while being moved, movement would feel jerky and unrefined. Am I misinterpreting the issue here?

rjaltman commented 6 years ago

@AcademyInPeril, I think @Watercycle is trying to argue that having the event show as droppable on two different dates does not seem like acceptable behavior, since a date should only be dropped on a single date. While you are right, there would be some awkwardness trying to transition if we forced day highlighting too much, the event snapping to the right indicates there is already some sort of "ownership" by the item's position that indicates what really should be highlighted.

My personal feelings on this are that we shouldn't show both highlighted, and of course you can keep dragging the event on top of the calendar. One solution is to turn off highlight on both, or just pick one and not the other if you are not hovering (preferably the right if that is what the event goes to upon dropping it at that position). I think I sort of see where you are going with movement UX there...it certainly might feel sudden or discontinuous...but this sort of is as well. Sudden transition to the next day once you have hit this threshold is kind of expected behavior, in my opinion. I might...completely be confusing this. I'm sorry...

I think I overly worried about this when we first found the bug, mostly because we were on a binge of finding strange behavior in Monthly since #113 was such an important PR. Now that I revisit it, this is a small issue, but one that those trying to break your platform trying to test it would probably still note. Therefore, I still feel like more discussion would help just so we know whether or not to apply some fix, and if we do, what kind of solution we use.

(Please correct me if I am misinterpreting either of you here.)

SorenSpicknall commented 6 years ago

I believe I understand now; I misinterpreted the initial screenshot. Is this only a highlighting issue, or does it actually allow events to be simultaneously dropped on both highlighted dates in monthly view? If the former, we can simply designate better highlighting behavior.