Implement Default Event Invite Category

vkoves commented 5 years ago

Description

This adds UI in the edit profile page to make it so you can switch your default event invite category, and makes it so that the default_event_invite_category is actually used. Here's a screenshot of the edit profile page:

screenshot from 2019-02-16 13-40-16

I should probably write some tests for this, but I wanted to get it into code review so folks could take a peek and make sure everything is happy.

Resolves #389.

Type of Pull Request

Based on the contributor's guide, this PR is of type:

[x] Development (feature-branch -> dev)
[ ] Hotfix (hotfix-branch -> master)
[ ] Release (release-branch -> master)
[ ] Other

Requestor Checklist

Requestor: Put an x in all that apply. You can check boxes after the PR has been made.

Reviewer: If you see an item that is not checked that you believe should be, comment on that as part of your review.

[ ] Code Quality: I have written tests to ensure that my changes work and handle edge cases
[ ] Code Quality: I have documented my changes thoroughly (using JSDoc in Javascript)
[x] Process: I have linked relevant issues, marking issues that this PR resolves
[x] Process: I have requested at least as many reviews required for this PR type (2 or 3)
[x] Process: I have added this PR to the relevant quarterly milestone
[x] Process: I have tested this PR locally and verified it does what it should

How This Has Been Tested

Tested locally with a few users, including one who had their default set, and a brand new user who had no categories yet.

vkoves commented 5 years ago

You would think I would know our CI and linting rules well enough to not have multiple commits just for fixing them. Well, you'd be wrong :laughing:

Watercycle commented 5 years ago

And yeah I typically squash my commits now for that reason - less git history noise.

vkoves commented 5 years ago

@Watercycle - merged with dev and fixed the one conflict I had due to the ERB lint PR. Like mentioned in my previous commit, take a look at my category helper and see if you are happy with that

vkoves commented 5 years ago

@Watercycle - updated!

Watercycle commented 5 years ago

All good!

vkoves / carpe