Add ERB Lint and Switch all HTML Files to Spaces

vkoves commented 5 years ago

Description

This adds erb-lint to our CI, documents it in the README, and fixes all errors.

Resolves #363.

Type of Pull Request

Based on the contributor's guide, this PR is of type:

[x] Development (feature-branch -> dev)
[ ] Hotfix (hotfix-branch -> master)
[ ] Release (release-branch -> master)
[ ] Other

Requestor Checklist

Requestor: Put an x in all that apply. You can check boxes after the PR has been made.

Reviewer: If you see an item that is not checked that you believe should be, comment on that as part of your review.

[x] Code Quality: I have written tests to ensure that my changes work and handle edge cases
[ ] Code Quality: I have documented my changes thoroughly (using JSDoc in Javascript)
[x] Process: I have linked relevant issues, marking issues that this PR resolves
[x] Process: I have requested at least as many reviews required for this PR type (2 or 3)
[x] Process: I have added this PR to the relevant quarterly milestone
[x] Process: I have tested this PR locally and verified it does what it should

How This Has Been Tested

Tested locally by running:

bundle exec erblint --lint-all

vkoves commented 5 years ago

Tip: This is 95% just white space changes, even if it looks huge. I'd recommend actually skimming through all the changes once, then disable whitespace in the GitHub diff to see what I actually changed.

Watercycle commented 5 years ago

@vkoves Did you convert these manually or with a formatter? The latter is much quicker to approve 😋

vkoves commented 5 years ago

@Watercycle - it was manual, but if you filter out whitespace changes, you'll see the code didn't change

vkoves / carpe