Closed vkoves closed 5 years ago
Merging with dev
added ERB lint, so we'll see if that passes or if I have some fixes to do
Update: It found one tiny thing, but now we are all good :smiley:
Since I added a new controller action and I even found a bug with it before, I've added two basic tests in commit d6ee777
Description
This adds the
/schedule/beta
route, which now shows a very basic Vue prototype that displays the current user's categories, like so:You can see this for yourself on Carpe test. This PR also adds a new
/users/:id/categories
route that returns the requested user's categories as a JSON, which is the nicer way to get data from RoR into JS, rather than nastyvar something = <%= ruby_var %>
.Finally, this also (per Ruby's requirements for webpack) moves us away from
npm
and toyarn
. This is generally preferred in the front-end world anyway (we recently made a similar change at work), but for more details on why Yarn is better, read here.Also worth nothing: The overall goal of this PR is to:
Type of Pull Request
Based on the contributor's guide, this PR is of type:
feature-branch
->dev
)hotfix-branch
->master
)release-branch
->master
)Requestor Checklist
Requestor: Put an
x
in all that apply. You can check boxes after the PR has been made.Reviewer: If you see an item that is not checked that you believe should be, comment on that as part of your review.
How This Has Been Tested
Tested locally and on Carpe test to ensure that this can actually deploy. Also still passes CI, with some tweaks and improvements made to the CI to fix an issue where it was complaining about
yarn
.