vkoves / carpe

Scheduling for the modern age - an UNMAINTAINED indigoBox project
http://carpe-uno.herokuapp.com
0 stars 0 forks source link

Prevent Editing Hosted Events on BE #395

Closed vkoves closed 5 years ago

vkoves commented 5 years ago

Description

This PR not only prevents users from editing hosted events on the BE, but adds a ton of schedules_controller tests that act as sanity checks and specifically check for cases around hosted events.

Since Matt's FE editing lock PR has not been merged, this means you should have an error saving if you modify anything on a hosted event other than the category, which is the intended behavior!

Part of #370.

Type of Pull Request

Based on the contributor's guide, this PR is of type:

Requestor Checklist

Requestor: Put an x in all that apply. You can check boxes after the PR has been made.

Reviewer: If you see an item that is not checked that you believe should be, comment on that as part of your review.

How This Has Been Tested

Tested manually by making sure I could still use my schedule and by making sure I was prevented from making any changes to hosted events. Also ran automated tests.

vkoves commented 5 years ago

Update: I discovered myself what the bug was and fixed it since I opened this PR. This should now be working properly!

vkoves commented 5 years ago

@Watercycle - updated!