Add Email Confirmation & Style Devise Emails

vkoves commented 5 years ago

Description

This PR adds email confirmation using Devise's confirmable, and also does the following:

Adds email previews for Devise emails
Improves Devise email styling to be in line with Carpe email styles
Updates welcome email to mention email confirmation

:warning: Release Note

Once this is released, we must run:

User.all.each do |user|
  user.send_confirmation_instructions
end

I believe this will send the confirmation email to all existing users, as otherwise they will be locked out of their accounts without explanation. The good news is it will tell them if they try to sign in and there's a resend button on the login page.

Screenshots

Welcome Email	Confirmation Email	Reset Password Email

This PR resolves #103.

Type of Pull Request

Based on the contributor's guide, this PR is of type:

[x] Development (feature-branch -> dev)
[ ] Hotfix (hotfix-branch -> master)
[ ] Release (release-branch -> master)
[ ] Other

Requestor Checklist

Requestor: Put an x in all that apply. You can check boxes after the PR has been made.

Reviewer: If you see an item that is not checked that you believe should be, comment on that as part of your review.

[ ] Code Quality: I have written tests to ensure that my changes work and handle edge cases
[ ] Code Quality: I have documented my changes thoroughly (using JSDoc in Javascript)
[x] Process: I have linked relevant issues, marking issues that this PR resolves
[x] Process: I have requested at least as many reviews required for this PR type (2 or 3)
[x] Process: I have added this PR to the relevant quarterly milestone
[x] Process: I have tested this PR locally and verified it does what it should

How This Has Been Tested

Tested with an existing account and a new account to confirm that email confirmation is working and that the little script I will run in Heroku will work. Please check my work and test it yourself too though!

vkoves commented 5 years ago

@Watercycle - it would help if I had run the tests and not just trusted CI then, wouldn't it :sweat_smile: I'll look into that and fix the typo

vkoves commented 5 years ago

@Watercycle - I have fixed the typo, fixed test and linting issues, and merged in dev with your CI fixes, so CI now passes :smiley:

vkoves / carpe