vkoves / carpe

Scheduling for the modern age - an UNMAINTAINED indigoBox project
http://carpe-uno.herokuapp.com
0 stars 0 forks source link

Fix Event Color Not Changing On Monthly View #428

Closed Watercycle closed 5 years ago

Watercycle commented 5 years ago

Currently, monthly events tiles do not update their category color when you change an event's category through the overlay panel category selector. This PR fixes that.

I'm not sure if there was a reason why, but temp-evnt-id was only being tracked on weekly events. The other part to this PR was just adding the appropriate selector to update the monthly event tiles.

Issue described here: https://github.com/vkoves/carpe/pull/414#pullrequestreview-232579738

Type of Pull Request

Based on the [contributor's guide][contrib-guide], this PR is of type:

Requestor Checklist

Requestor: Put an x in all that apply. You can check boxes after the PR has been made.

Reviewer: If you see an item that is not checked that you believe should be, comment on that as part of your review.

How This Has Been Tested

Tested locally.

1) Create two categories with different colors 2) Place an event on the schedule 3) Switch to monthly view 4) Click (edit) the event 5) Change the category

vkoves commented 5 years ago

@Watercycle - it looks like CI found a small linting issue! Please take a look at that, but I will manually QA this to check your fix.

vkoves commented 5 years ago

Still looks good to me!