vkoves / carpe

Scheduling for the modern age - an UNMAINTAINED indigoBox project
http://carpe-uno.herokuapp.com
0 stars 0 forks source link

Remove Migration That Prevented Deploy #430

Closed vkoves closed 5 years ago

vkoves commented 5 years ago

Description

So there were a variety of issues with migrations running against the prod database, due to event invites having foreign key constraints and that causing problems with renames and such. I was able to fix some of them by dropping the old constraints, but in 3a130d2, I commented this migration out since it just was not needed on prod and thus failed. The foreign key being removed just didn't exist.

@Watercycle - I wanted to get your feedback on this, and see if it might be time for us to squash our migrations to get rid of old nonsense and back and forths we had.

This PR should go into the release branch, which should then go into master via a hotfix and develop via PR #429.

Type of Pull Request

Based on the contributor's guide, this PR is of type:

Requestor Checklist

Requestor: Put an x in all that apply. You can check boxes after the PR has been made.

Reviewer: If you see an item that is not checked that you believe should be, comment on that as part of your review.

How This Has Been Tested

The commented out migration worked on prod, so I assume this should work.

vkoves commented 5 years ago

Good idea! Since that will be a bit of a project, I have opened #431 in Q2 2019 for that.