search

vkoves / carpe

Scheduling for the modern age - an UNMAINTAINED indigoBox project
http://carpe-uno.herokuapp.com
0 stars 0 forks source link

Remove SendGrid credentials from Repository #87

Open vkoves opened 7 years ago

vkoves commented 7 years ago

Curerntly indigoBox's SendGrid credentials are in plaintext in this file: https://github.com/vkoves/Carpe/blob/master/config/environment.rb

This should be moved to an environment variable or something like it so that it is not in the repository.

Watercycle commented 7 years ago

If we move this to an environment variable will we still be able to build and run Carpe locally?

vkoves commented 7 years ago

Build and run would work fine, but emailing won't work without changing the sendgrid initializer.

kkoves commented 7 years ago

We should take another look at this, since this issue hasn't been touched since January... Here's an article I found that offers multiple approaches to load environment variables locally, so that we can still test email functionality on our development environments. Also, we have to change the password after making this change, since the current one will still be in the file's modification history.

SorenSpicknall commented 6 years ago

@vkoves, in the interest of security, we should probably fast-track this one.

vkoves commented 6 years ago

Good point @AcademyInPeril. I've moved it back into the milestone.

vkoves commented 6 years ago

Moving to Q2 for immediate action