vkoves / electrify-chicago

Learn about Chicago's most polluting buildings, and what they can do to clean up their act!

http://electrifychicago.net

16 stars 10 forks source link

Add Historical Graph to Building Details Over Any Tracked Column #107

Closed vkoves closed 4 months ago

vkoves commented 5 months ago

Description

Adds a basic BarGraph component (powered by D3) and implements it on the building details page to show a switchable graph of a few of the historically tracked columns. Here's a demo with Marina Towers;

Total Emissions	Electric Use

Fixes #4

Testing Instructions

Please describe the tests/QA that you did to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

netlify[bot] commented 5 months ago

Deploy Preview for radiant-cucurucho-d09bae ready!

Name	Link
Latest commit	dac8087c1651d2b6e009588da6885945a47921bc
Latest deploy log	https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/667b79286d20660008880880
Deploy Preview	https://deploy-preview-107--radiant-cucurucho-d09bae.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alexkcode commented 5 months ago

The pytest bug is a pandas issue related to this numpy issue: https://github.com/numpy/numpy/issues/26710

alexkcode commented 5 months ago

According this comment on that issue thread, as long as we're using pandas == 2.2.2 and above we should be fine. But if we use any earlier version we must pin down a numpy version below 2.0.0.

alexkcode commented 4 months ago

Getting an intermittent issue of D3 not installing with docker compose up --build, looking into it currently.

vkoves commented 4 months ago

@alexkcode I had that happen due to caching or having an existing build, I had to do a fresh Docker build to make sure it installs dependencies.