vkoves / electrify-chicago

Learn about Chicago's most polluting buildings, and what they can do to clean up their act!

http://electrifychicago.net

16 stars 10 forks source link

Keep Unreported Records For Python Grade Calculation #132

Closed AlexanderTyan closed 2 weeks ago

AlexanderTyan commented 1 month ago

Description

Change/rerun data preprocessing to keep unreporting records.

Relates to issue #129, because we need non-reporting data in the CSV to calculate reporting grades

Testing Instructions

Please describe the tests/QA that you did to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

netlify[bot] commented 1 month ago

Deploy Preview for radiant-cucurucho-d09bae ready!

Name	Link
Latest commit	a5cd8c97b337d6696d8ca1124f899927c7da16ee
Latest deploy log	https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/6734164a7c1701000893a9e4
Deploy Preview	https://deploy-preview-132--radiant-cucurucho-d09bae.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vkoves commented 1 month ago

@AlexanderTyan - it looks like you'll need to update the Python tests scripts, because now there's more records in the historical data than it expected!

AlexanderTyan commented 4 weeks ago

@vkoves i updated the test output csv according to the newly changed processing + updated expected answers in tests to match what's in there. the updated test_output.csv now has 'Not Submitted' rows, as well as 'Submitted Data' and 'Submitted' rows.

[edit: grammar]

AlexanderTyan commented 4 weeks ago

This is the old test_output.csv for the record: test_output_backup.csv

vkoves commented 4 weeks ago

@AlexanderTyan - So I did find one issue, it looks like this change breaks the historical graphs, I think because now they are getting empty data 😭

Prod	Deploy Preview

I think this can be fixed by making each graph filter out empty data - do you feel comfortable giving that a try, would you like me to try and fix it, or would you like to pair up on it next Chi Hack Night?

AlexanderTyan commented 3 weeks ago

@vkoves yeah, let's pair up next ChiHackNight!