Closed SuragNuthulapaty closed 1 year ago
Name | Link |
---|---|
Latest commit | 1b112d06f42116af22f3b6ee96a91ff5c0fddbd3 |
Latest deploy log | https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/648f4fc7c4b5220008c7820c |
Deploy Preview | https://deploy-preview-27--radiant-cucurucho-d09bae.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
@SuragNuthulapaty - do you want to tackle adding this to the UI during next week's CHN? I don't want to merge just raw data since it's pretty hard to debug and validate
@vkoves sounds good, ill get to work on it
@vkoves i just remembered I won't be able to make CHN this week, I've pushed up all my work and it's ready to be reviewed
@vkoves This is now ready to check again
@SuragNuthulapaty - excellent work (particularly with the custom pluralize function), but have a few last minor comments
@SuragNuthulapaty - did import
not end up working, or are you still working on this?
@vkoves I'm still working on it but it's not looking too good. I can't seem to figure out anything.
@SuragNuthulapaty - not sure if it helps, but here's a commit where I have a JSON import: https://github.com/vkoves/electrify-chicago/commit/01f7f7405d673726bf89c7f12608a087adef6ee6
I did have to tweak the TSConfig originally to get that to work, but it should work fine now for all files I'd think
@vkoves That worked, I fixed everything now. Hopefully that's the last changes needed for now.
@SuragNuthulapaty - so sorry, I actually found a bug. Here's the bottom of Hermann Hall on prod:
On your branch those tiles don't appear:
I'm guessing because those don't have category rankings (which is fine), but the tiles expect that every tile does.
@vkoves I think this should hopefully be good now
Created a script that ranks and gives statistics specifically based on each building type, not across the whole of Chicago.
To run the script, run
python3 add-context-by-property-type.py
You can see the output of the rankings in
/data/dist/building-benchmarks.csv
by looking at the columns that are Specific Category+"RankByPropertyType"The output of the building statistics are in
data/dist/building-statistics-by-property-types.json
Resolves #24