Closed SuragNuthulapaty closed 10 months ago
Name | Link |
---|---|
Latest commit | 0b618e533a9d972428b6546bc222b3a3b318b537 |
Latest deploy log | https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/64eee31fc7babf00070ee33e |
Deploy Preview | https://deploy-preview-40--radiant-cucurucho-d09bae.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Haven't reviewed this yet, but it gives me a chuckle that IIT is still #1 😆
We need to tag Crown Hall as an IIT property, and maybe shift to using building ID instead of slugs for owners, since that's probably more stable year over year
@SuragNuthulapaty - ope, I found a bug. We show buildings that never submitted, like the United Center but the page doesn't work because there's no data:
https://deploy-preview-40--radiant-cucurucho-d09bae.netlify.app/building/united-center/
I think changing the yellow warning to a red warning and saying they never submitted then hiding all the info we don't have should be sufficient, and that will solve Issue #25
Oh one more thing - I think old buildings are getting included in rankings, like "Hyde Park West Apartments" on the homepage. This shouldn't happen, since it isn't really fair to compare buildings in separate years where the data collection could have been different or even just building standards have changed.
@vkoves This is the raw csv file:
I see that united center has submitted data, I am not sure why it's not working. In that row all the data is there as normal.
Alright going to try digging into some of these data quirks. Turns out for some reason now buildings sometimes get prefixed with (ILNUMBER) -
, so we should try and trim that out:
Update: Fixed in f4b884fa
So thinking about this more, I think the negative ranking is happening because we are running the add context by property type ranking before the data split by year, which likely means we are ranking across all buildings across all years, so Marina Towers may be ranked as #1,999 dirtiest of #2,000 buildings in the raw data set, but then there's only say #1,000 buildings in the latest year, so the rank gets inverted to 1000 - 1999 = -999. We should likely only rank buildings against buildings in the latest year to simplify this.
To fix this, add-context-by-property-type.py
should filter to buildings with data in the latest year, and only apply rankings to that data set. That means older buildings won't be counted in the rank or get a rank.
Just took a look and i believe I got it wrong. The python3 scripts/clean-and-pare-down-data_all_years.py
should be on line 89, not 91, with two lines above it being brought down. Also, the reverence to building-benchmarks.csv
is correct, the next two scropts will correctlyupdate the data in ./dist/
to use on the main site.
Marina Towers is now reporting zero values for gas use, so the front-end rankings calculation needs to account for this:
UI | Source Data (just Marina towers, 2021 at top) |
---|---|
Viktor's note: We should also try to verify if all buildings reporting zero use actually have that
District cooling and heating no longer shows medians, a good example is Herman Hall.
Prod | This Branch |
---|---|
Large owners and building images are now fixed with a pivot to IDs! 🎉
I've updated the natural gas tile to provide more information on a building's gas use based on whether or not it uses district steam! We may want to move this up later on, since we should really highlight the few fully gas free buildings:
Fully Gas Free (e.g. Marina Towers) | No Local Gas (e.g. Crown Hall) |
---|---|
Created and added new data from 2021, with a new data process that combines historic data with the 2021 data, allowing buildings with only past data like the Art Institute to still show useful information..
⚠️ Warning - this is currently a destructive update, since you cannot see 2020 data on buildings that reported their 2021 data. We should likely follow this up with a PR tackling historical emissions (Issue #4).
Details
The new data:
src/data/source/ChicagoEnergyBenchmarking.csv
is the source filesrc/data/source/ChicagoEnergyBenchmarkingAllNewestInstances.csv
are all the newest unique building ID'ssrc/data/source/ChicagoEnergyBenchmarkingThisYear.csv
is all submitted data for the current year (2021)When displaying, an alert will pop up if the webpage is using old (not 2021) data:![image](https://github.com/vkoves/electrify-chicago/assets/77648585/9e323f83-c426-41a4-8a20-69f82a708722)
Known Issues To Resolve
(IL###) -