vkoves / electrify-chicago

Learn about Chicago's most polluting buildings, and what they can do to clean up their act!
http://electrifychicago.net
9 stars 5 forks source link

Add Some Municipal Property Owners & Buildings (CPS, CHA & City of Chicago) #65

Closed SuragNuthulapaty closed 5 months ago

SuragNuthulapaty commented 5 months ago

Description

Adds CPS, CHA, and City of Chicago property owners Tags properties that belong to CPS, CHA, and City of Chicago with their respective property owners.

Fixes #12

Testing Instructions

As I can't run the project on my end, I am using neflify to check

Checklist:

netlify[bot] commented 5 months ago

Deploy Preview for radiant-cucurucho-d09bae ready!

Name Link
Latest commit e2ebb7216c5ae336c536ad119df47c745acae509
Latest deploy log https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/65a74af8bad1050008406ddc
Deploy Preview https://deploy-preview-65--radiant-cucurucho-d09bae.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SuragNuthulapaty commented 5 months ago

@vkoves Additionally, I have not pushed the data set I used for city of Chicago or the scripts I used to process the main set for all 3 property owners. Should I commit those as well? There are also some more things to do. I have not updated each of the 3 new property owners with correct logos. Also, CHA buildings might not be exhaustive but it is a start.

SuragNuthulapaty commented 5 months ago

image Case in point for unchanged logo. This is a CHA property that shows the Northwestern Logo. I did not know what sort of constraints you had on these images so I did not add any

vkoves commented 5 months ago

@SuragNuthulapaty - just taking a quick starting peek, but what's your data source on the city buildings? Gallery 37 and MSI are definitely privately owned.

Screenshot from 2024-01-10 17-36-28

I'd make sure we're quite conservative with these - I'd rather have only five buildings tagged but know they are right than to falsely accuse a building of being owned by someone it isn't.

SuragNuthulapaty commented 5 months ago

Downloaded from this link, I have the dataset on my local computer and can push it up if you want me to. https://www.chicago.gov/city/en/depts/dcd/supp_info/city-owned_land_inventory.html

Also, for MSI specifically, the data set from the city says its owned by city, which is concerning image

SuragNuthulapaty commented 5 months ago

image

similar story for Gallery 37, I'll look into finding a more accurate data source

vkoves commented 5 months ago

I wonder if the land is owned by the city and somehow the building is leasing it from them? But we want to know about city owned buildings

vkoves commented 5 months ago

Also @SuragNuthulapaty for the logos I think a 1000px wide transparent PNG is perfect, but if you add anything I can help you edit it if needed!

SuragNuthulapaty commented 5 months ago

@vkoves just pushed up the csv I am using, looking at it we might be able to use the Managing Organization column to determine if the city actually owns the building, by checking if management is AIS (Department of Assets, Information and Services )

I'll also push up the scripts I am using if you want to take a look at it, along with some logos

SuragNuthulapaty commented 5 months ago

@vkoves just pushed up a few more logos, along with the updated bulding-custom-info.constant.vue. I believe the only thing left to do is scan through the tagged buildings to ensure they are tagged properly.

Also, not sure if I'll be able to make any more meetings for a while, so this is where ill leave this issue off from.

vkoves commented 5 months ago
  1. Optimize find_city_buildings to use a map of address to building IDs, so you're not looping through all benchmark buildings for each city owned building. Make sure to skip buildings that aren't managed by AIS earlier.
  2. Move these scripts into scripts/building-owners directory to keep them isolated from main data parsing
  3. Note that these exist in the README, and to check them for more info (since we added docs in each script)
vkoves commented 5 months ago

Looks good to me after our last meeting and reading the code, good work and thanks for tackling this!