vkoves / electrify-chicago

Learn about Chicago's most polluting buildings, and what they can do to clean up their act!
http://electrifychicago.net
9 stars 5 forks source link

Fix Python Data Tests & Add to CI Via GitHub Actions #80

Closed vkoves closed 2 months ago

vkoves commented 3 months ago

Description

Adds a GitHub action to run the new tests Alex added, ensuring no new PRs can go through that break data processing. See PR #68 for the original PR adding the tests.

Fixes #79

Testing Instructions

Ran tests locally and in CI

Checklist:

netlify[bot] commented 3 months ago

Deploy Preview for radiant-cucurucho-d09bae ready!

Name Link
Latest commit 534ab06da89a99cef73034bde284b258be07e7c9
Latest deploy log https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/65fe4d5eaf24fc0008cbc204
Deploy Preview https://deploy-preview-80--radiant-cucurucho-d09bae.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vkoves commented 3 months ago

@alexkcode - this PR might interest you, I'm trying to get your tests working on all PRs!

Should we limit this to only run on changes of certain files (related StackOverflow) maybe just .csv and .py changes?

vkoves commented 3 months ago

Looks like the tests now run but have two failures, we'll have to fix or disable those:

Screenshot from 2024-03-20 09-10-24