vkoves / electrify-chicago

Learn about Chicago's most polluting buildings, and what they can do to clean up their act!
http://electrifychicago.net
9 stars 5 forks source link

add docker-entrypoint #90

Closed derekeder closed 2 months ago

derekeder commented 2 months ago

Description

Note that you will likely need to run docker-compose build before this will work for you.

Testing Instructions

Checklist:

netlify[bot] commented 2 months ago

Deploy Preview for radiant-cucurucho-d09bae ready!

Name Link
Latest commit 7b19c15ec3ce323b0c493fd9e2bda0ef1d828eca
Latest deploy log https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/662579564a3b3500081d6063
Deploy Preview https://deploy-preview-90--radiant-cucurucho-d09bae.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

derekeder commented 2 months ago

it looks like tests are failing for reasons unrelated to these changes:

 -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED tests/data/scripts/unit/test_clean_all_years.py::test_str_values_remain_the_same_as_origin - AssertionError: assert '41.83292416819927' == '41.832924168'
  - 41.832924168
  + 41.83292416819927
  ?             +++++
=================== 1 failed, 11 passed, 1 warning in 0.78s ====================
Error: Process completed with exit code 1.
gaylem commented 2 months ago

Here's the PR for the README changes: https://github.com/vkoves/electrify-chicago/pull/91

derekeder commented 2 months ago

@gaylem thx! I updated the readme already in this PR. Does it look right to you?

derekeder commented 2 months ago

@gaylem thx - done!

vkoves commented 2 months ago

@derekeder and @gaylem - the Pytest seems to be failing, it looks like you tweaked the test data and might need to tweak the tests

derekeder commented 2 months ago

@vkoves huh not sure how those extra rows were added. removed them and tests are passing now

vkoves commented 2 months ago

Gayle approved so I will merge!