vkoves / electrify-chicago

Learn about Chicago's most polluting buildings, and what they can do to clean up their act!
http://electrifychicago.net
9 stars 5 forks source link

refactor tests to be less implementation-dependent #96

Closed pldorn closed 1 month ago

pldorn commented 1 month ago

Description

A proposed refactor of the clean_all_years python unit tests. This version is less dependent upon the current implementation in clean_and_pare_down_data_all_years.py. The motivation is to make future refactors in the data processing code easier.

This approach largely focuses on a single fixture that wraps the results from the process method of clean_and_pare_down_data_all_years.py and then tests expected behavior against it.

Testing Instructions

Checklist:

netlify[bot] commented 1 month ago

Deploy Preview for radiant-cucurucho-d09bae ready!

Name Link
Latest commit 05af0f85ea2cd6c7b124de2915413ab53fd995a3
Latest deploy log https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/663ae3f03e735b00088dd290
Deploy Preview https://deploy-preview-96--radiant-cucurucho-d09bae.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.