search

vktrbr / optimization_ml

Optimization in ML
MIT License
10 stars 1 forks source link

Type refactoring #4

Closed Laxharoth closed 2 years ago

Laxharoth commented 2 years ago

Made some types more specific and matched return type signature

vktrbr commented 2 years ago

Thank you! Refactoring looks nice. I have a question for you: what is the motivation for writing'x1:Real = .. instead of x1 = ..

Laxharoth commented 2 years ago

what is the motivation for writing'x1:Real = .. instead of x1 = ..

The type hinting was assuming x1 to be Any. Sorry I didn't add that in the commit message, maybe was just the IntelliSense I was using