vkurko / calendar

Full-sized drag & drop JavaScript event calendar with resource & timeline views
https://vkurko.github.io/calendar/
MIT License
969 stars 82 forks source link

unique classes in views #177

Closed piotrm73 closed 10 months ago

piotrm73 commented 10 months ago

I have suggestion to give unique classes in views, because now timeGridDay, timeGridWeek and resourceTimeGridWeek all are in '.ec-week' container nad this makes it difficult to customize views in css... for example I have many resources in resourceTimeGridWeek and I had to change some css there but it spoils the timeGridDay and timeGridWeek views

vkurko commented 10 months ago

Actually, it has already been implemented in v2.1.0. Please check this comment.

vkurko commented 10 months ago

I hope I can close this issue.

piotrm73 commented 10 months ago

ok. I installed latest version and fortunatelly it's working on older nodejs...but I have just one more suggestion about resource view

image

it would be good to separate .toolbar from the rest (.ec-header, .ece-all-day, ec-body) because when it's many resources you must use oferflow:auto or scroll, and it would be good to attach overflow to container with just resources data, and toolbar should not be scrolled then

vkurko commented 10 months ago

Thanks for the suggestion. For a large number of resources, this view would be more suitable. Hope it gets implemented someday.