search

vkuznet / transfer2go

Distributed, loosely couple agent-based transferring system
MIT License
8 stars 2 forks source link

Add deployment script #34

Closed rishiloyola closed 7 years ago

rishiloyola commented 7 years ago

This script will help to setup the golang and our project. Later on, I will make it configurable to change the golang version and our project version.

vkuznet commented 7 years ago

Rishi, sorry but this is plain wrong. You made few assumptions which are not generalize, to name a few:

rishiloyola commented 7 years ago

Hi Valentin,

I wrote this script to deploy VMs for the testing. This script can be useful in the future. That's why I have created a separate folder under which we can collect all the useful scripts. Yes, you are right this script is not generic. You can reject this PR.

On Jul 21, 2017 10:09 PM, "Valentin Kuznetsov" notifications@github.com wrote:

Rishi, sorry but this is plain wrong. You made few assumptions which are not generalize, to name a few:

  • you assumed that the node is based on yum installer
  • you assumed that you can write to /home/golang and /usr/lib/golang
  • you write your changes to user area .bashrc file We don't need deployment script, since we can give end-users static executable. Then can download it and run it on their own system (yum based or not), in their own environment, home or not, etc.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vkuznet/transfer2go/pull/34#issuecomment-317050019, or mute the thread https://github.com/notifications/unsubscribe-auth/AJoIV8j9hXtH-yQBX4F-gfF7N-Gpm5Fcks5sQNRUgaJpZM4OdD3f .

vkuznet commented 7 years ago

ok, clear. I'll reject PR and you may keep script around for testing.

On 0, Rishi notifications@github.com wrote:

Hi Valentin,

I wrote this script to deploy VMs for the testing. This script can be useful in the future. That's why I have created a separate folder under which we can collect all the useful scripts. Yes, you are right this script is not generic. You can reject this PR.

On Jul 21, 2017 10:09 PM, "Valentin Kuznetsov" notifications@github.com wrote:

Rishi, sorry but this is plain wrong. You made few assumptions which are not generalize, to name a few:

  • you assumed that the node is based on yum installer
  • you assumed that you can write to /home/golang and /usr/lib/golang
  • you write your changes to user area .bashrc file We don't need deployment script, since we can give end-users static executable. Then can download it and run it on their own system (yum based or not), in their own environment, home or not, etc.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vkuznet/transfer2go/pull/34#issuecomment-317050019, or mute the thread https://github.com/notifications/unsubscribe-auth/AJoIV8j9hXtH-yQBX4F-gfF7N-Gpm5Fcks5sQNRUgaJpZM4OdD3f .

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/vkuznet/transfer2go/pull/34#issuecomment-317080554