Closed ikappaki closed 2 years ago
Hi @ikappaki!
perhaps there is performance implications
Exactly! Column inference is recursive (to the depth of 4), so a worst-case scenario could be very bad (e.g. 16^4=65536 columns). Example that already has abysmal performance:
(->> (range 16)
(map (fn [_]
(->> (range 16)
(map (fn [_]
(into {} (map-indexed vector (range 16)))))))))
That said, I think it should be pretty rare to have such a big nested structure, so it's probably fine to bump the limit to 32. I released a new version (Free: 1.3.272, Pro: 1.3.342) with the bump.
Hi,
the maximum number of columns the
view:table
currently support is restricted to 16. This number seems to be arbitrary. My expectation would be that either there is no max limits or it is a much larger number.To reproduce
view:table
.The table is displayed as a single column item, instead of a 17 column table:
The max columns value is hardcoded in vlaaad.revial.view/infer-columns:
It is not obvious why a limit is imposed here (perhaps there is performance implications) , possible improvements I can think of:
Happy to submit a PR.
Thanks