sssoja commented 2 years ago

What changes have you made?

Updated the replace value to false when calling the navigate function from "svelte-routing"
navigate is an abstraction of navigate from the history.js of the History interface
Previously the history stack was replacing the current entry in the history stack instead of adding a new one. This was preventing the user from navigating backward and forwards using the browser

Which issue(s) does this PR address?

91

How to test

Run npm install and open up the web survey on localhost:5000
Navigate through the survey and use the arrows in the browser to go backward and forwards
The user should be able to navigate linearly based on the questions they've answered

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/fly-websurvey/fly/3vga6mbEbA5vA3YXizEDSfKxXcNZ
✅ Preview: https://fly-git-bugfix-navigation-fly-websurvey.vercel.app

nandanrao commented 2 years ago

LGTM!

vlab-research / fly

Bugfix/history stack #101

What changes have you made?

Which issue(s) does this PR address?

91

How to test