Closed Spazzy757 closed 1 year ago
Name | Link |
---|---|
Latest commit | fc2a8b957d0a0974e4fd4b1b1d23b0da666aa366 |
Latest deploy log | https://app.netlify.com/sites/vlab-research/deploys/648ad0648fd207000833ee3e |
Name | Link |
---|---|
Latest commit | fc2a8b957d0a0974e4fd4b1b1d23b0da666aa366 |
Latest deploy log | https://app.netlify.com/sites/virtuallab-videos/deploys/648ad0644d5ef900087ca00d |
I like the cleanup a lot!
However, I'm a bit confused about the file structure for /values. There is values/integrations/fly and values/integrations/kafka. But then there is still values/staging.yaml and values/test.yaml etc...
That seems a bit confusing to me, why not have a consistent structure?
Hm. Also, trying to run make dev
it on a new machine, it fails because some of the apps are missing secrets? Such as "bot-envs"?
Hm. Also, trying to run
make dev
it on a new machine, it fails because some of the apps are missing secrets? Such as "bot-envs"?
Yes, this is due to this line: https://github.com/vlab-research/fly/pull/124/files#diff-7a622d6368356a8d43646cae2132855752983918b924ca7326be4fd128c37570R33-R35
This is legacy as you need the env file in the dev folder (Its not saved in the repo and I haven't changed this)
I like the cleanup a lot!
However, I'm a bit confused about the file structure for /values. There is values/integrations/fly and values/integrations/kafka. But then there is still values/staging.yaml and values/test.yaml etc...
That seems a bit confusing to me, why not have a consistent structure?
This was used to separate the "services" from "fly". Currenly staging cockroachdb is deployed as part of the "chart of charts" so there is not need to seperate it until we are ready top remove this dependency
Changelog
gbv-
prefix where possible for integration tests in favour offly-
prefixNotes