(#9) Load Reloadly credentials from db

vlab-research / fly

The Fly Survey platform

Other

2 stars 3 forks source link

(#9) Load Reloadly credentials from db #28

Closed calufa closed 3 years ago

calufa commented 3 years ago

TODO:

[x] Add DB
[x] Add go mod tidy to dinersclub and formcentral
[x] Add Auth() method to provider interface
[x] Add cache to Auth()
[x] Remove ReloadlyConfig env vars
[x] Fix test json style
[x] Push new Docker image
[x] Adjust infra (environment variables, new docker image tag)
[x] Add Realoadly env vars to CircleCI
[x] Test e2e

netlify[bot] commented 3 years ago

✔️ Deploy Preview for vlab-research canceled.

🔨 Explore the source changes: 19a89996a7f2bab1c68b90aa8c9fc8d4a65816bd

🔍 Inspect the deploy log: https://app.netlify.com/sites/vlab-research/deploys/616e4aa290fb690008172a7c

nandanrao commented 3 years ago

Looks great!

The only thing about the cache, thinking about it: most likely you will actually want a different ReloadlyService for each authorization (right now the service stores the token it recieves from authorizing in a mutable field in the struct)

calufa commented 3 years ago

Yep, makes sense.

calufa commented 3 years ago

RE: https://github.com/vlab-research/fly/pull/28#discussion_r722846012

TestDinersClubErrorsWhenProviderNotListed it is almost an exact copy of TestDinersClubErrorsOnNonExistentProvider, https://github.com/vlab-research/fly/blob/main/dinersclub/dinersclub_test.go#L103-L128. In TestDinersClubErrorsOnNonExistentProvider, the code seems to indicate that the error is reported to BotParty, and not reported upstream, hence, https://github.com/vlab-research/fly/blob/main/dinersclub/dinersclub_test.go#L127.

The test mainly seems to be checking for BotParty payload, more than anything else.

nandanrao commented 3 years ago

Ah right, there is an error reported. Makes sense, sorry!