vlab-research / vlab

The Virtual Lab platform!
https://studies.vlab.digital
Other
3 stars 2 forks source link

If recruitment data is behind, adopt should change window #208

Open nandanrao opened 1 year ago

nandanrao commented 1 year ago

Right now, adopt relies on an "opt window" -> https://github.com/vlab-research/vlab/blob/main/adopt/adopt/malaria.py#L95

It also relies on RecruitmentData for spend -> https://github.com/vlab-research/vlab/blob/main/adopt/adopt/malaria.py#L86

However, if the job that collects RecruitmentData is failing and for some reason the latest recruitment data isn't available, adopt seems to think $0 has been spent and estimates the price of all respondents to be very cheap. Which is a problem!

Adopt should either fail or change it's opt window to match the latest available recruitment data. (which would be the same as failing if the adset duration was actually a long time, rather than the current arbitrary 2 day default)