search

vlabella / GLE

GLE - Graphics Layout Engine
BSD 3-Clause "New" or "Revised" License
19 stars 9 forks source link

Always links with libzstd static library instead of shared library #32

Open ryandesign opened 1 month ago

ryandesign commented 1 month ago

If zstd is found, the GLE build always links with the libzstd static library instead of the shared library:

https://github.com/vlabella/GLE/blob/d770ed475aedeef6a59f653e5f31f1680deafaff/src/gle/CMakeLists.txt#L133-L140

https://github.com/vlabella/GLE/blob/d770ed475aedeef6a59f653e5f31f1680deafaff/src/gui/CMakeLists.txt#L97-L101

Users on Unix generally expect shared libraries to be used. What's the reason for requiring the static library?

vlabella commented 1 month ago

Static libraries are preferred on windows.