search

vlachoudis / bCNC

GRBL CNC command sender, autoleveler and g-code editor
GNU General Public License v2.0
1.58k stars 535 forks source link

Problem with the islands if the edges match #1040

Open MARIOBASZ opened 6 years ago

MARIOBASZ commented 6 years ago

If the first segment match with the first segment of the island, there is conflict and error in the route image

image

MARIOBASZ commented 6 years ago

Apparently using split2contours in place of eulerize, is immune to the direction of rotation of the shapes.

Harvie commented 6 years ago

What works better for you? split2contours() or eulerize()? I've written eulerize() method, because i didn't know that split2contours() exists :-) I guess split2contours() will work better, because it's older and therefore more tested than eulerize() which is very experimental.

MARIOBASZ commented 6 years ago

Sorry, the comment should go in union. In what I've tried, eulerize sometimes generates whimsical routes, with split2contour the routes have been correct, both in union, intersection and difference.

Harvie commented 6 years ago

Good to know. I was going to use split2contours instead of eulerize.