search

vlachoudis / bCNC

GRBL CNC command sender, autoleveler and g-code editor
GNU General Public License v2.0
1.57k stars 533 forks source link

Error In Pendant.py #1125

Open qvisionsa opened 5 years ago

qvisionsa commented 5 years ago

I think there is an error in line 231 it is written f = open(os.path.join(webpath,page),"r") this way the web server can't open image files (jpg, png etc) I thin the correct is f = open(os.path.join(webpath,page),"rb")

Harvie commented 5 years ago

Have you tried if that fixes your problem? Isn't that affecting loading of text files like .html, .css or .js?

If you've tested this, can you please make pull request with this modification, so i can merge it?

qvisionsa commented 5 years ago

This change fixed my problem instead. It seems that isn't affecting other file types, as I'm loading CSS, js, png HTML without a problem. Anyway, I will test it thoroughly and I will let you know. For the moment it's fine!

Harvie commented 5 years ago

If this does not affect the current pendant, but only your development version of pendant, that's not real issue. you might just include this modification with your new pendant once that's finished. no need to resolve this separately.