search

vlachoudis / bCNC

GRBL CNC command sender, autoleveler and g-code editor
GNU General Public License v2.0
1.54k stars 528 forks source link

Please relax opencv-python requirement #1761

Open yarda opened 1 year ago

yarda commented 1 year ago

There is:

"opencv-python==4.5.5.62 ; "

It's causing problems when doing distro packaging, because there usually is not this exact version in the distro repository. Could you relax it with e.g. >, < operators?

yarda commented 1 year ago

Moreover on Fedora the package is named 'python3-opencv' and provides 'python3-opencv', bit I will probably open Fedora bug to explicitly provide opencv-python.

yarda commented 1 year ago

Fedora bug regarding the provides: https://bugzilla.redhat.com/show_bug.cgi?id=2142632

Harvie commented 1 year ago

Fedora bug regarding the provides:

you have to differentiate between provides within fedora packaging system and provides within python packaging system... not sure which of these are you refering to...

yarda commented 1 year ago

AFAIK the fedora packaging system deps are generated by rpm-build from the setup.py requirements. I.e. at the moment there is: install_requires=[ "opencv-python==4.5.5.62;" ... Which is translated to the RPM package requirement by rpm-build resulting in the following RPM error:

Error: 
 Problem: conflicting requests
  - nothing provides python3.11dist(opencv-python) = 4.5.5.62 needed by bCNC-0.9.14.52~20221017git523f1ec7-3.fc38.noarch

I am trying to get bCNC package into Fedora repository, Fedora review ticket: https://bugzilla.redhat.com/show_bug.cgi?id=1684603