search

vlachoudis / bCNC

GRBL CNC command sender, autoleveler and g-code editor
GNU General Public License v2.0
1.54k stars 528 forks source link

Errors in profile with pocket activated #1782

Closed MARIOBASZ closed 1 year ago

MARIOBASZ commented 1 year ago

Hello people. Dodo Le Saumer, unless I'm wrong and I'm missing something, in Pocket within profile it takes the offset value to calculate stepover, which seems wrong to me: line 4410 in cnc.py, pocket takes these parameters: newblocks, abs(offset), CNC.vars["stepover"] / 50, name, True Instead it should be declared: diameter = CNC.vars["diameter"] stepover = CNC.vars["stepover"]/100.0 and pocket take newblocks, diameter, stepover, name, True

MARIOBASZ commented 1 year ago

If you perform a profiling operation on multiple blocks (more than 2), with pocket enabled, the operations are performed on the wrong blocks.