search

vlachoudis / bCNC

GRBL CNC command sender, autoleveler and g-code editor
GNU General Public License v2.0
1.54k stars 528 forks source link

GRBL1.py override code not functioning correctly #1835

Closed rschell closed 1 year ago

rschell commented 1 year ago

I noticed when I use the Override slider to temporary adjust either the Feed Rate or the Spindle speed. The selected item, feed or spindle, continue to change beyond the desired set point. Code appears continue to issue override strings of either 10 or 1 increment/decrements until the control is reset.

The problem here is the GRBL1 code issues the appropriate override string but the override status variable is not adjusted, so GRBL1 continues to issue override strings. Doesn't appear to be any tracking of the override commands issued.

My fix would be to adjust the override status variable "OvFeed" and "OvSpindle" by the appropriate amount in GRBL1, so GRBL1 will stop issuing overrides when the status variable equals the target value. Requires 5 additional statements for each the Feed and Spindle Overrides.

Anybody else had issues with the Feed and Spindle override controls?

rschell commented 1 year ago

Found that the $10 setting on my grblHAL controller was not reporting the override values. Changing the $10 value from 187 to 251 also fixed the issue.