search

vlachoudis / bCNC

GRBL CNC command sender, autoleveler and g-code editor
GNU General Public License v2.0
1.54k stars 528 forks source link

Fix unused errorReport variable #1855

Closed dwrobel closed 4 months ago

dwrobel commented 9 months ago

Fixes: Utils.py:213:9: F841 local variable 'errorReport' is assigned to but never used.

Harvie commented 9 months ago

does the underscore mean the variable will be ignored by the test? maybe we can remove that functionality completely, when nothing is using it. what's the point of calling that anyway?

dwrobel commented 9 months ago

does the underscore mean the variable will be ignored

Thanks to underscore we assign a value to an existing variable (not to the one which doesn't exist), see: https://github.com/search?q=repo%3Avlachoudis%2FbCNC%20_errorReport&type=code.

Harvie commented 4 months ago

thanks