vlaci / openconnect-sso

Wrapper script for OpenConnect supporting Azure AD (SAMLv2) authentication to Cisco SSL-VPNs
GNU General Public License v3.0
300 stars 131 forks source link

fixed bugs where first openconnect arg is deleted #130

Closed epichub closed 1 year ago

epichub commented 1 year ago

have not really double checked all possible inputs here, but this patch fixes the where where given the cli arguments; openconnect-sso .. -- args1topenconnect where both https://github.com/vlaci/openconnect-sso/blob/master/openconnect_sso/cli.py#L124 and https://github.com/vlaci/openconnect-sso/blob/master/openconnect_sso/cli.py#L125 removes the first argument - effectively removing two arguments "--" and "args1openconnect"..

vlaci commented 1 year ago

Originally changed by https://github.com/vlaci/openconnect-sso/commit/9ed960f5c660fcb76a18b80a5ade286cff9b62e4

https://github.com/vlaci/openconnect-sso/issues/30

epichub commented 1 year ago

Hey @vlaci ! First of all: thanks for making this package! Second, the reference to #30 - how should this patch relate to that? maybe a test? Third, I am not sure what is wrong with the coding style (I am not used to writing code that ships, just research prototypes.. :D)

vlaci commented 1 year ago

I think I understand the misunderstanding about the original faulty PR.