config: use keyring.get_password() as a workaround for a kwallet bug

vlaci / openconnect-sso

Wrapper script for OpenConnect supporting Azure AD (SAMLv2) authentication to Cisco SSL-VPNs

GNU General Public License v3.0

295 stars 127 forks source link

config: use keyring.get_password() as a workaround for a kwallet bug #26

Closed MrAnno closed 4 years ago

MrAnno commented 4 years ago

The current implementation of the keyring KWallet backend contains a regression that breaks the autofill feature of openconnect-sso: get_credential() returns the password as a string.

https://github.com/jaraco/keyring/commit/0b7b41f93f66ab11038ff50993cb43e9bf1f64af (I'm about to report and fix this upstream.)

Using get_password() is sufficient in my opinion.

MrAnno commented 4 years ago

jaraco/keyring#463

vlaci commented 4 years ago

Thank you!