Allow configuring a command to be automatically run when disconnecting from VPN (take 2)

jherland commented 3 years ago

I configure my SSH with ControlMaster connections that must be closed when I disconnect from VPN, otherwise they are left stale and existing and future SSH session are left hanging/wedged.

To accomodate this, the last patch in this series teaches openconnect-sso automatically run a configured command on VPN disconnection. In my case, I run a shell script that does ssh -O exit ... on my connections, although this doesn't matter from openconnect-sso's POV.

Otherwise the other patches are only tangentially related:

Patch#1 fixes an obvious bug in the develop branch.
Patch#2 stops openconnect-sso from crashing when the config file cannot be written. It allows me to control the openconnect-sso configuration via home-manager (which stores a symlink to a read-only file in the Nix store).
Patch#3 moves code from the async _run() into the sync run(). Specifically it moves the running of the openconnect subprocess which does not benefit from being async. This also fixes the control flow when aborting openconnect with Ctrl+C.

This supersedes https://github.com/vlaci/openconnect-sso/pull/32, but is based on develop instead of master, as I found it easier to get this done on top of those changes.

vlaci commented 3 years ago

I'll check it out tomorrow.

jherland commented 3 years ago

Pushed updated version with requested changes.

vlaci commented 3 years ago

Thank you for your contribution. Will try to publish a new release this weekend.

vlaci / openconnect-sso

Allow configuring a command to be automatically run when disconnecting from VPN (take 2) #33