vlaci / openconnect-sso

Wrapper script for OpenConnect supporting Azure AD (SAMLv2) authentication to Cisco SSL-VPNs
GNU General Public License v3.0
280 stars 119 forks source link

Fixed MFA #64

Closed marekdedic closed 2 years ago

marekdedic commented 2 years ago

Should close #53

vlaci commented 2 years ago

I cannot try this out anymore, I hope that it works :)

marekdedic commented 2 years ago

I've been using it daily and it has worked for me so far 🙂

Thanks

marekdedic commented 2 years ago

Hi, sorry to bother you, but could you please release this? I'd like to get back to not depending on my own fork :) Thanks!

ojg commented 2 years ago

I also came here looking for a solution to using openconnect-sso with Yubikey. So I am anxiously waiting for a new release with this functionality.

Thank you for a great piece of software that has made work from home so much easier for me.

vlaci commented 2 years ago

I have released 0.8.0 but doesn't want to upload to pypi without testing. If you could try it manually from here and report back if it works for you that would be much appreciated.

ojg commented 2 years ago

Thank you very much for providing this for me to test.

I'm not an expert pip user so I might have done something wrong during the install. If I just do "pipx install openconnect-sso-0.8.0/" then I will get "ModuleNotFoundError: No module named 'PyQt5.QtWebEngineWidgets'" even though "pipx list" shows pyqt5 installed.

So I had to do "pipx install openconnect-sso[full]" and then "pipx install --force openconnect-sso-0.8.0/" before it would run at all without pyqt5 error. "openconnect-sso --version" now reports 0.8.0

However, it didn't work for me, just like with 0.7.3, no popup window appeared after selecting "secret key" and pressing said key.

paalge commented 2 years ago

I don't get a window in 0.8.0 either. No error message with log level debug.

marekdedic commented 2 years ago

Hi, I just did

$ git checkout v0.8.0
$ make clean
$ make dist
$ pip install dist/openconnect-sso-0.8.0.tar.gz

And I have version 0.8.0 installed successfully, and I do get the popup window.

marekdedic commented 2 years ago

Hi, @vlaci, do you please have any plans on releasing this to pip? Works for me like a charm ever since the merge...

Thanks!